Patch for Feature Request Similar to (gtypist) Computer Touch-Typing

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for Feature Request Similar to (gtypist) Computer Touch-Typing

jaffa225man
This post was updated on .
I'm not a piano expert.  Surprise!  I found this great program and decided to try learning with it.

I like all the skill modes, but think another similar mode would be helpful to me.  Since I'm no expert with the piano, but have learned computer touch-typing, it seems that a similar mode to that of gtypist would be helpful.  Gtypist doesn't allow for (backspace) correction of mistakes.  As soon as an error is keyed, it continues to the next letter, which I think helps train good self-pacing.  In other words, your "Play Along" mode comes close by allowing to set the speed to whatever you're comfortable with, but I think it would be better if there's a non-forced speed, similar to the "Follow You" mode that waits for you to play notes, but continues on the keystroke whether or not an error was made.  "Follow You" mode is still probably preferred to most people, so I think it would be best to just add this "Follow You Allowing Errors" (or whatever you want to call it) mode to the options already there, perhaps just as a "Setup"->"Preferences" option.

I hope that's a sane request, as I don't know the piano, and that it wouldn't require too much work.
Thanks for the consideration,

  Luke
Reply | Threaded
Open this post in threaded view
|

Re: Feature Request Similar to (gtypist) Computer Touch-Typing

jaffa225man
This post was updated on .
Well, I think I've added that feature fairly satisfactorily, although I wasted way too much time on it.  For anyone else who wants to try it (or to include it in the official source), here's my patch: pianobooster-0.6.7~svn156-FollowThroughErrors.patch.  As previously described it creates a new "Follow Through Errors" check box option in the "Setup"->"Preferences" dialog, and with that checked, is still only enabled when "Skill" is set to "Follow You"

Edit:
Actually, I've redone it to work better for those dyslexic among us to be yet more similar to gtypist.  Now if the wrong note is played but that wrong note was the proper note for the one after the failed one, it error-marks the failed note and validates the one after it (even without being in the proximity zone).  I think this is better yet to help keep the rhythm going.
As an example from gtypist:  If the supposed to be typed text is "How that was", but "How tat was" is typed, gtypist highlights the error ("_") like so: "How t_at was", without faulting everything following the missing "h".  My previous patch wouldn't necessarily fault everything after the mistake (since it throws out subsequent extraneous notes while out of a note's zone), but if one is playing fast enough, the notes may be in proximity enough for exactly that to happen.  As I said, this new patch should fix that.  If you've already applied the previous patch, you should reverse it, and then apply this new one (this is not a patch needing the other patch; they're mutually exclusive).
Here's the new one (also for pianobooster-0.6.7~svn156): FollowThrough1.patch

Thanks again,

  Luke
Reply | Threaded
Open this post in threaded view
|

Re: Patch for Feature Request Similar to (gtypist) Computer Touch-Typing

romul
In reply to this post by jaffa225man